Skip to content

Fix Tests #893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 20, 2024
Merged

Fix Tests #893

merged 3 commits into from
Sep 20, 2024

Conversation

KernelDeimos
Copy link
Contributor

No description provided.

The ifError alias for error in tapjs appears to no longer exist.
This one was rather strange. These tests fail even if parallel test
running is disabled (tap --jobs=1). Explicitly listening to a different
port on each test case solved the issue. I then tried waiting for the
next event cycle using a setTimeout(..., 0) on t.end and this actually
worked. I suspect then that the server doesn't really "close" until the
event loop turns once more - very interesting.
After the previous changes there were a few lingering asserts that
didn't match the names in the newest version of tap. These were
relatively trivial to fix, although interestingly the meaning of the
'includes' synonym changed at some point from "match" to "has"; these
tests were written at the time "includes" meant "match".
@KernelDeimos KernelDeimos merged commit 60cf5ec into master Sep 20, 2024
0 of 11 checks passed
@KernelDeimos KernelDeimos deleted the eric/fix-tests branch September 20, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant